Waterfall Charts in Python - starter code

(Christopher Csiszar) #21

I’m not sure I understand. The function itself is callable through waterfall() already. Did you mean the package name?

0 Likes

(Jeremy Howard (Admin)) #22

According to the readme, it’s called quick_charts()

0 Likes

(Christopher Csiszar) #23

I see what you mean. Would you prefer:

from waterfallcharts import waterfall as wf
plot = wf.waterfall_matplot(a,b)

The package name is waterfallcharts, which contains the quick_charts.py source file, itself containing the definition of a waterfall plotting function waterfall(). Did I overcomplicate this naming convention?

0 Likes

(Jeremy Howard (Admin)) #24

I would say so :wink:

Best, I think, to move waterfall.py into the root of your tree, and call it waterfall_chart, then name the function plot, so you can simply:

import waterfall_chart
waterfall_chart.plot(...)

How would that be?

1 Like

(Christopher Csiszar) #25

I now understand how this could have been made simpler. Many thanks for the recommendation!

The function is now callable through

import waterfall_chart
waterfall_chart.plot(...)

As you suggested.

1 Like