`nbdev-ci` doesn't work?

doyu · February 16, 2023, 6:17pm

nbdev-ci doesn’t work and I looked into the following file. It seems that git status never fails so that my nbdev-ci always return false. How does this work on your environment?

github.com

fastai/workflows/blob/master/nbdev-ci/action.yml#L50


      
            pip install -U git+https://github.com/fastai/fastcore.git
            pip install -U git+https://github.com/fastai/ghapi.git
            pip install -U git+https://github.com/fastai/execnb.git
            pip install -U git+https://github.com/fastai/nbdev.git
          else
            pip install -U nbdev
          fi
          echo "Doing editable install..."
          test -f setup.py && pip install -e ".[dev]"
          echo "Check we are starting with clean git checkout"
          if [[ `git status --porcelain -uno` ]]; then
            git diff
            echo "git status is not clean"
            false
          fi
          echo "Trying to strip out notebooks"
          nbdev_clean
          echo "Check that strip out was unnecessary"
          git status -s # display the status to see which nbs need cleaning up
          if [[ `git status --porcelain -uno` ]]; then
            git status -uno

doyu · February 17, 2023, 1:38pm

follow-up: the issue is not about git status but it’s just about the different version of nbdev. Closed!

manu · March 4, 2023, 3:02pm

Not sure if this is the same problem…but since a couple of weeks ago, I’m not able to get a clean push in my nbdev (v2) repo. It always fails with the Detected unstripped out notebooks but when I clone the repo in my machine and perform nbdev_clean and, afterwards, check with git status -s, everything is fine.

Any clue?

manu · March 4, 2023, 5:34pm

I got it working: I just had to set up the conda environment from scratch all over (oddly enough, conda/mamba update --all didn’t help)