@jeremy the problem is I’m hijacking settings.ini
to make sure images get the right url:
doc_path = images/copied_from_nb
doc_host = https://nbdev.fast.ai
doc_baseurl = {{site.baseurl}}/images/copied_from_nb/
so naturally, when the jupyter is converted to html, that url is converted to this:
<p>{% include image.html height="600" max-width="800" file="{{site.baseurl}}/images/copied_from_nb/./my_icons/fastai_logo.png" %}</p>
Which is invalid liquid. to fix this I suppose I could:
- Monkey patch nbdev to allow me to inject the baseurl outside settings.ini
- Monkey patch the function that wraps the includes
- Perhaps something else?
I generally try to avoid monkey patching, if possible because it feels dangerous for long term stability so not sure. But I’m also hesitant to try to force nbdev to change to this use case which seems pretty specific? Please let me know your thoughts
EDIT: made some corrections to some typos in my answer just now. Please re-read if haven’t already.