How to contribute to fastai2 repo: Found a bug and the fix, now what?

[YangL (YangLu)]

So, found a problem in 08_vision.data.ipynb by running nbdev_test_nbs.

The fix involves adding
from …vision import *
to data/block.py and adding
from fastai2.vision.data import *
to the lesson 8 notebook.

Question is, now what?
I’m not even sure it is a bug for everybody.
Shall I send in a pull request? Am I even supposed to do that?
How does pull request of a jupyter notebook even work? (beautifully? )

Thanks. If I posted at the wrong place again, please do let me know.

[sgugger]

This means that the functions are not in the right order in the notebook. I’ll look at it in the morning. We can’t have the notebook importing the module it’s trying to build.

[YangL (YangLu)]

I’m looking at

Submitting PR to fastai V2

Submitting Pull Request to fastai V2 I am a Wiki thread! You can edit me. Creating a PR using gh - the official GitHub CLI Install gh from here Create a conda environment with fastai2 requirements, include nbdev. a) git clone https://github.com/fastai/fastai2 b) cd fastai2 c) conda env create -f environment.yml d) source activate fastai2 e) pip install -e ".[dev]" f) Create an editable install of fastcore outside of fastai2 (see docs here) Run nbdev_install_git_ho…

In general, is there a centralised location for bug reports?

So I assume that the point
Checkout to new feature branch (this is where new feature/bug-fix should be made)
git checkout -b <enter--relevant-feature-branch-name>

Does not apply here.

[philchu (Phillip Chu)]

@YangL

In general, is there a centralised location for bug reports?

Perhaps start with opening a new issue at the github repo, to start the discussion and eventually the pull request of the fix.