Github etiquette

I’m new-ish to github (especially to group projects!) and I’m not sure on the etiquette-- I think I’ve set up initializing a conv_learner model with LSUV, but I haven’t had a chance to test it very much (and I’m just pulling the actual LSUV code from ). Should I share it as a pull request as is, or is there some better way to post the code (given that it’s possibly not 100% ready for prime time)? I won’t be able to work on it for the next few days, but wanted to share what I have in case it’s useful for others.

1 Like

Usually there is a contributing.MD in the project. The etiquette depends on the project. So open the project in the web UI, press T and search for Contributing.mD file and read that. If there is none then you are free to open up a PR and see how the project contributors respond.

Pressing T in github’s UI opens up something like this

1 Like


Definitely best to push it to fastai if you’re not going to be able to work on it further for a bit. In the PR, say what testing you’ve done, ideally with a little gist to a notebook showing the main results (I’m guessing you’ve already got such a notebook anyways…)