Submitting PR to fastai V2

fastai fastai dev
41

What do you do with the branch locally once the merge is done?
Do you merge?

42

If you have processed item 8 in the list above, that means you have merged and committed your changes in your local repository.

You then proceed with item 9 above which sends a pull request to the remote/master repository for them to pull your changes from your local forked repository.

This maybe helpful

43

I donā€™t see any mergeā€¦

44

As an alternative to using gh as mentioned above, I used Github Desktop.

Followed the list in order as @arora_aman posted except for numbers 1 and 10 which use gh. Once you have committed the changes head over to Github Desktop:

  1. (if not already done) Use the Add existing repository to import your local fastai repository into Github Desktop

  2. Click on Branch and you will see the branch you created with git checkout

  3. Click on Create Pull Request and follow the prompts.

Really easy to use Github Desktop

45

FYI - Just updated to work with the latest bits.

1 Like