Hi! I was getting the following error on the github test CI action:
Run echo "Check we are starting with clean git checkout"
[13](https://github.com/nuvo3d/pipeline_v1/runs/8117697476?check_suite_focus=true#step:5:14)Check we are starting with clean git checkout
[14](https://github.com/nuvo3d/pipeline_v1/runs/8117697476?check_suite_focus=true#step:5:15)Trying to strip out notebooks
[15](https://github.com/nuvo3d/pipeline_v1/runs/8117697476?check_suite_focus=true#step:5:16)Traceback (most recent call last):
[16](https://github.com/nuvo3d/pipeline_v1/runs/8117697476?check_suite_focus=true#step:5:17) File "/opt/hostedtoolcache/Python/3.10.6/x64/bin/nbdev_clean", line 33, in <module>
[17](https://github.com/nuvo3d/pipeline_v1/runs/8117697476?check_suite_focus=true#step:5:18) sys.exit(load_entry_point('nbdev==2.2.9', 'console_scripts', 'nbdev_clean')())
[18](https://github.com/nuvo3d/pipeline_v1/runs/8117697476?check_suite_focus=true#step:5:19) File "/opt/hostedtoolcache/Python/3.10.6/x64/lib/python3.10/site-packages/fastcore/script.py", line 117, in _f
[19](https://github.com/nuvo3d/pipeline_v1/runs/8117697476?check_suite_focus=true#step:5:20) return tfunc(**merge(args, args_from_prog(func, xtra)))
[20](https://github.com/nuvo3d/pipeline_v1/runs/8117697476?check_suite_focus=true#step:5:21) File "/opt/hostedtoolcache/Python/3.10.6/x64/lib/python3.10/site-packages/nbdev/clean.py", line 136, in nbdev_clean
[21](https://github.com/nuvo3d/pipeline_v1/runs/8117697476?check_suite_focus=true#step:5:22) if fname is None: fname = get_config().nbs_path
[22](https://github.com/nuvo3d/pipeline_v1/runs/8117697476?check_suite_focus=true#step:5:23) File "/opt/hostedtoolcache/Python/3.10.6/x64/lib/python3.10/site-packages/nbdev/config.py", line 199, in get_config
[23](https://github.com/nuvo3d/pipeline_v1/runs/8117697476?check_suite_focus=true#step:5:24) cfg = Config(cfg_file.parent, cfg_file.name, extra_files=extra_files, types=_types)
[24](https://github.com/nuvo3d/pipeline_v1/runs/8117697476?check_suite_focus=true#step:5:25)TypeError: Config.__init__() got an unexpected keyword argument 'types'
And I realized the version installed with
python -m pip install git+https://github.com/fastai/nbdev.git@master
was nbdev-2.2.9 (not released in pip nor conda yet).
Running nbdev_clean on my machine with nbdev-2.2.8 (the current latest version in pip) did not throw that error.
I ran the same install command of the CI and I got then the same error as above.
Replacing
python -m pip install git+https://github.com/fastai/nbdev.git@master
with
python -m pip install nbdev
in github/workflows/test.yaml seems to solve the problem.
Should we change that line permanently? It makes sense that we would like to run CI with the latest version instead of the nightly version.